Add automatic username suggestion with suffix when username is taken#29
Open
bendnema wants to merge 2 commits intoCMU-313:mainfrom
Open
Add automatic username suggestion with suffix when username is taken#29bendnema wants to merge 2 commits intoCMU-313:mainfrom
bendnema wants to merge 2 commits intoCMU-313:mainfrom
Conversation
Pull Request Test Coverage Report for Build 21602199733Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR implements automatic username suggestions when a chosen username is already taken.
Changes:
Modified
User.uniqueUsername()in src/user/create.js to append "suffix" instead of spaces + base32 numberUpdated register.js to display inline suggestions: "Username taken. Maybe try 'test123suffix' instead."
Shows suggestions on both live validation (when blurring field) and form submission
Closes #1